feat: track and optionally enforce resource limits during building #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle Base-specific execution state into dedicated types in base/execution.rs to reduce inline modifications to upstream-mirrored files. The upstream is_tx_over_limits() signature is preserved (with one additional parameter for DA footprint override), and Base-specific limit checking is added after the upstream check via is_tx_over_base_limits().
Extract execution time limit tracking into separate types in the base/ module to minimize diffs against upstream: - BaseBuilderCtx: block-level execution time limit - BaseFlashblocksCtx: per-batch execution time tracking - BaseExecutionState: cumulative execution time state This keeps modifications to existing files minimal and additive.
Avoids needing to re-export FlashblocksConfig from the private flashblocks module by having new() accept the computed value directly.
Add BaseMetrics to track when transactions are excluded due to execution time limits. Metrics include tx execution time, remaining budget, exceeded amount, tx gas, and remaining gas at the point of rejection. Also logs tx_hash with each rejection warning.
When false (default), transactions that exceed execution time limits are logged and metrics recorded, but not rejected. Only the first transaction to exceed the limit triggers logging/metrics. When true, transactions exceeding limits are marked invalid and excluded from the block.
Also fix tests to set enforce_resource_metering=true for tests that expect transactions to be rejected due to execution time limits.
Add tests verifying that when enforce_resource_metering=false, transactions exceeding execution time limits are still included (for both standard and flashblocks builders).
cody-wang-cb
reviewed
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--builder.enforce-resource-meteringflag to control whether limits are enforced or just observed