Skip to content

various task template improvements #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2025
Merged

various task template improvements #432

merged 2 commits into from
Oct 17, 2025

Conversation

leopoldjoy
Copy link
Contributor

@leopoldjoy leopoldjoy commented Oct 13, 2025 •
edited
Loading

This PR makes the following improvements to the root README.md file for task templates:

  1. Adds a general note about how to, and the need to, create VALIDATION.md files.
  2. Changes task completion wording to be EXECUTED (instead of DONE).

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 13, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

danyalprout
danyalprout previously approved these changes Oct 13, 2025
View reviewed changes
@cb-heimdall
Copy link
Collaborator

Review Error for meyer9 @ 2025-10-13 21:53:25 UTC
User failed mfa authentication, see go/mfa-help

jackchuma
jackchuma reviewed Oct 14, 2025
View reviewed changes
@cb-heimdall cb-heimdall dismissed danyalprout’s stale review October 14, 2025 15:01

Approved review 3333056052 from danyalprout is now dismissed due to new commit. Re-request for approval.

@leopoldjoy leopoldjoy requested a review from jackchuma October 14, 2025 15:03
@leopoldjoy leopoldjoy merged commit 62fbfc8 into main Oct 17, 2025
4 checks passed
@leopoldjoy leopoldjoy deleted the leopoldjoy-patch-2 branch October 17, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meyer9 meyer9 meyer9 approved these changes

@jackchuma jackchuma jackchuma approved these changes

@tobidae-cb tobidae-cb tobidae-cb approved these changes

@danyalprout danyalprout danyalprout left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@leopoldjoy @cb-heimdall @danyalprout @meyer9 @jackchuma @tobidae-cb