Skip to content

Conversation

jjtny1
Copy link
Contributor

@jjtny1 jjtny1 commented Sep 12, 2025

This PR update the incident multisig for mainnet

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 12, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

Copy link

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

  1. All upgrade folders have a validations/ subdirectory
  2. Each validations/ folder contains at least one config file:
    • base-nested.json (for Coinbase validation)
    • base-sc.json (for Base SC validation)
    • op.json (for OP validation)
  3. All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

To disable the validation check please add a validation.yml file to your upgrade folder with 'disabled': true

Copy link

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

  1. All upgrade folders have a validations/ subdirectory
  2. Each validations/ folder contains at least one config file:
    • base-nested.json (for Coinbase validation)
    • base-sc.json (for Base SC validation)
    • op.json (for OP validation)
  3. All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

To disable the validation check please add a validation.yml file to your upgrade folder with 'disabled': true

@@ -0,0 +1,4 @@
OP_COMMIT=ef7a933ca7f3d27ac40406f87fea25e0c3ba2016
BASE_CONTRACTS_COMMIT=cab46f4c34f11e22640ec3073aa6f0b46cdaa1b7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest commit is 132ba0f33cb455ffff783924588df8864767bd9c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the new validation tool for this. I believe Thanh updated the state-diff tool to support the expected json output format

Copy link

github-actions bot commented Oct 2, 2025

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

  1. All upgrade folders have a validations/ subdirectory
  2. Each validations/ folder contains at least one config file:
    • base-nested.json (for Coinbase validation)
    • base-sc.json (for Base SC validation)
    • op.json (for OP validation)
  3. All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

To disable the validation check please add a validation.yml file to your upgrade folder with 'disabled': true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants