Skip to content

Conversation

@cb-jake
Copy link
Collaborator

@cb-jake cb-jake commented Nov 3, 2025

Summary

This PR adds support for the experimental experimental_requestInfo method to the Account SDK, enabling applications to request user profile information such as name, email, phone number, and physical address.

Changes made:

  • Added experimental_requestInfo method support in the Signer class
  • Added generic handling for all experimental methods (methods starting with experimental_)
  • Created test app components to demonstrate the new functionality
  • Added UI section for "Base Profile" methods in the test app

Key files modified:

  • packages/account-sdk/src/sign/base-account/Signer.ts - Core signer logic
  • examples/testapp/src/components/RpcMethods/method/experimentalMethods.ts - Method definition
  • examples/testapp/src/components/RpcMethods/shortcut/experimentalShortcuts.ts - UI shortcuts
  • examples/testapp/src/pages/index.page.tsx - Test app integration

How did you test your changes?

Testing performed:

  • ✅ Verified the new experimental_requestInfo method is properly routed to popup
  • ✅ Confirmed all experimental methods (those starting with experimental_) are handled generically
  • ✅ Tested the test app UI displays the new "Base Profile" section correctly
  • ✅ Validated the method accepts the expected parameters (requests array with type and optional fields)
  • ✅ Confirmed backward compatibility - existing methods continue to work as expected

Test scenarios covered:

  • Request info with different combinations of required/optional fields (name, email, phoneNumber, physicalAddress)
  • Verified popup integration works correctly for the new experimental method
  • Ensured the generic experimental method handler doesn't interfere with existing functionality

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 3, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-jake cb-jake marked this pull request as ready for review November 17, 2025 22:44
@cb-jake cb-jake changed the title [WIP] add support for base_requestInfo Add support for base_requestInfo Nov 17, 2025
@cb-jake cb-jake changed the title Add support for base_requestInfo Add support for experimental_requestInfo Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants