fix(infer): add repetition_penalty and CLI ngram parameters to prevent text looping - #73
Open
not-knope wants to merge 2 commits into
Open
fix(infer): add repetition_penalty and CLI ngram parameters to prevent text looping#73not-knope wants to merge 2 commits into
not-knope wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes text repetition/looping issues on dense or structured document pages reported in #55.
Problem:
When processing dense document pages (e.g. forms, government documents), the inference path can enter endless text repetition loops generating 8K–32K redundant tokens until \max_length\ is reached. The root cause is that
o_repeat_ngram_size=35\ only blocks repeating n-grams of exact length 35; shorter repeating phrases (8–15 tokens) fall between 35-gram sliding window boundaries and repeat infinitely.
Solution & Changes Made:
Fixes #55