fix(rbac): improve edit/create role page performance - #10346
fix(rbac): improve edit/create role page performance#10346karthikjeeyar wants to merge 5 commits into
Conversation
Signed-off-by: Karthik <karthik.jk11@gmail.com>
Signed-off-by: Karthik <karthik.jk11@gmail.com>
6b01305 to
8e8132a
Compare
Changed Packages
|
There was a problem hiding this comment.
@karthikjeeyar With searchMembers hard-coded to limit=100 and a catalog of 5K+ users, if more than 100 users match a term like "dev-", the user only sees the first 100 with no way to reach the rest. For better UX, we can think of adding a "Load more" button at the bottom of the dropdown that fetches the next 100 using offset-based pagination. We can also do it as follow up PR not a blocker for this PR.
@ShiranHi @tobiastal what's your thought on this ?
|
Yes, I noticed this limitation earlier as well. There is currently a cap of 100 items in the dropdown, and I agree there is room for improvement here, like I intentionally haven’t included that in this PR because it would be a new feature and I’d like to keep this change focused so that it can be safely backported. We can address the |
its-mitesh-kumar
left a comment
There was a problem hiding this comment.
Verified it with 5k+ users the crash issue has gone. PR can be merged once we addressed the above comments.
S_.2026-08-19.at.2.09.38.PM.mov
|
@karthikjeeyar The I'd like if we can stabilize |
fc7a214 to
be25a32
Compare
Signed-off-by: Karthik <karthik.jk11@gmail.com>
be25a32 to
f3688c0
Compare
|
@karthikjeeyar I'm getting slight lag of 1-1.5 seconds. I've added 270 users in create role page and if I try to add or remove added users, there is delay in click. Is this expected? Screen.Recording.2026-08-19.at.4.35.34.PM.mov |
Signed-off-by: Karthik <karthik.jk11@gmail.com>
|
@sanketpathak Good catch on the selection lag with a large number of members. The issue was already present, but hadn't been identified previously. All the auto-complete callback were re-created everytime and list item was not using a unique key. I've now memoized the autocomplete callbacks and fixed duplicate React keys, which addresses the underlying causes of the lag. PTAL Fix_dropdown_selection_issue.mov |
Signed-off-by: Karthik <karthik.jk11@gmail.com>
c710b4d to
6c00b46
Compare
Hey, I just made a Pull Request!
Improves RBAC create/edit role page performance.
Summary
searchMembers) fetching only the members assigned to a role (getMembersByRefs)getMembers()calls togetMembers(1, 1)for authentication checks (eg: to enable edit button in role page) instead of fetching all entitiesScreenshots:
Before fix
After fix
RBAC_Page_Performance_fixed.mov
How to test
Add the following to your
app-config.yamlundercatalog.locations:✔️ Checklist
Signed-off-byline in the message. (more info)