Skip to content

enabled knipReports for jaeger - #10329

Open
ibrahimcdz wants to merge 1 commit into
backstage:mainfrom
ibrahimcdz:workspace-jaeger/knip
Open

enabled knipReports for jaeger#10329
ibrahimcdz wants to merge 1 commit into
backstage:mainfrom
ibrahimcdz:workspace-jaeger/knip

Conversation

@ibrahimcdz

Copy link
Copy Markdown

Hey, I just made a Pull Request!

Enables Knip dependency reports for the [workspace-name] workspace, per #5992.

What changed

  • Set "knipReports": false"knipReports": true in workspaces/[workspace-name]/bcp.json

Notes for reviewers

This is a draft PR. I ran into some issues generating the Knip report locally — the yarn build:knip-reports command referenced in #5992's instructions doesn't exist as a top-level script in this repo currently; the closest equivalent I found was scripts/ci/generate-knip-report.js, which itself calls backstage-repo-tools knip-report and also didn't run cleanly for me locally. Rather than block on that, I'm opening this now so CI can generate the report directly, and I'll push follow-up commits addressing whatever it flags once I can see the output.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie

Copy link
Copy Markdown
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants