enabled knipReports for jaeger - #10329
Open
ibrahimcdz wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Enables Knip dependency reports for the
[workspace-name]workspace, per #5992.What changed
"knipReports": false→"knipReports": trueinworkspaces/[workspace-name]/bcp.jsonNotes for reviewers
This is a draft PR. I ran into some issues generating the Knip report locally — the
yarn build:knip-reportscommand referenced in #5992's instructions doesn't exist as a top-level script in this repo currently; the closest equivalent I found wasscripts/ci/generate-knip-report.js, which itself callsbackstage-repo-tools knip-reportand also didn't run cleanly for me locally. Rather than block on that, I'm opening this now so CI can generate the report directly, and I'll push follow-up commits addressing whatever it flags once I can see the output.✔️ Checklist
Signed-off-byline in the message. (more info)