Handle error returned by PebbleDB's NewIter method#4
Open
wock9000 wants to merge 1 commit intobaabeetaa:pebblefrom
Open
Handle error returned by PebbleDB's NewIter method#4wock9000 wants to merge 1 commit intobaabeetaa:pebblefrom
wock9000 wants to merge 1 commit intobaabeetaa:pebblefrom
Conversation
This pull request updates the `Iterator` and `ReverseIterator` functions in the PebbleDB integration to handle an additional return value from the `NewIter` method. Previously, `NewIter` was expected to return a single value, the iterator itself. However, a recent update to the underlying Pebble library has modified `NewIter` to return two values: the iterator and an error. ### Changes Made: - Modified the `Iterator` and `ReverseIterator` functions to capture and check the error returned by `NewIter`. - If an error is returned when calling `NewIter`, the error is handled appropriately by returning `nil` for the iterator and propagating the error up to the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
IteratorandReverseIteratorfunctions in the PebbleDB integration to handle an additional return value from theNewItermethod. Previously,NewIterwas expected to return a single value, the iterator itself. However, a recent update to the underlying Pebble library has modifiedNewIterto return two values: the iterator and an error.Changes Made:
IteratorandReverseIteratorfunctions to capture and check the error returned byNewIter.NewIter, the error is handled appropriately by returningnilfor the iterator and propagating the error up to the caller.