Changes made as you requested. #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thihaaung6245
commented
May 8, 2017
thihaaung6245
commented
- Updated Readme for configuring upsideArrowIndicator
- Update variable name from 'upsideArrowDirection' to 'isUpsideArrowIndicator'
- .gitignore updated for '.DS_Store'
- Set arrow default width and height to library owner default value
…on name changed. gitignore updated. Updated readme
azurechen
requested changes
May 9, 2017
| @@ -0,0 +1,243 @@ | |||
| ACTabScrollView | |||
Owner
There was a problem hiding this comment.
Why did you copy a README file here?
| // Contributed by Thiha Aung on 2017/5/8 | ||
| // 1. Added implementations for upside arrow direction | ||
| // 2. Added some inspectable to configure arrowView | ||
|
|
Owner
There was a problem hiding this comment.
You don't need to add these comments in the source code. We have git log
|
|
||
| // ADDED: | ||
| // 1. Set arrow item to up position | ||
|
|
| @IBInspectable open var arrowBackgroundColor: UIColor = UIColor.white | ||
| @IBInspectable open var arrowWidth : CGFloat = 12 | ||
| @IBInspectable open var arrowHeight : CGFloat = 7 | ||
| >>>>>>> 4bcac438ac34da53f3e7bd74ab50f7d6bca4f663 |
Owner
There was a problem hiding this comment.
Thanks for your code update! But please check the conflicts before you send a PR. And the following more are the same.
| @@ -1,3 +1,6 @@ | |||
| # OSX | |||
| .DS_Store | |||
|
|
|||
Owner
There was a problem hiding this comment.
.DS_Store should be a default ignored item. You don't need to add this line in .gitignore file.
If you still cannot ignore that. You may check this
http://stackoverflow.com/questions/18393498/gitignore-all-the-ds-store-files-in-every-folder-and-subfolder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.