feat: move collections away from worldserver config reload#219
Merged
Nyeriah merged 3 commits intoazerothcore:masterfrom Dec 24, 2025
Merged
feat: move collections away from worldserver config reload#219Nyeriah merged 3 commits intoazerothcore:masterfrom
Nyeriah merged 3 commits intoazerothcore:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the transmog collection loading mechanism to separate it from the general world server config reload, introducing a dedicated reload command for transmog-specific configuration and collections.
Key Changes:
- Extracted collection loading logic from
OnAfterConfigLoadinto a newLoadCollections()method that only runs on initial server startup - Added a new
.transmog reloadcommand for administrators to reload transmog configuration and collections independently - Collections are no longer reloaded automatically when world server config is reloaded
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/transmog_scripts.cpp | Modified OnAfterConfigLoad to only call LoadCollections() on initial startup, not during config reload |
| src/cs_transmog.cpp | Added new HandleReloadTransmogConfig command handler for manual transmog reload |
| src/Transmogrification.h | Added LoadCollections() method declaration |
| src/Transmogrification.cpp | Implemented LoadCollections() method with the collection loading logic extracted from the world script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.