Actually fix crash when using junk-to-gold module#34
Merged
Nyeriah merged 1 commit intoazerothcore:masterfrom Jul 24, 2025
Merged
Actually fix crash when using junk-to-gold module#34Nyeriah merged 1 commit intoazerothcore:masterfrom
junk-to-gold module#34Nyeriah merged 1 commit intoazerothcore:masterfrom
Conversation
Nyeriah
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My last fix attempt didn't work but this one does. There is a problem when using this module and the
junk-to-goldmodule. When picking up an item, the junk to gold module removes it from the world and the player but the item pickup function in this module still gets called. Then the module tries to retrieve the itemtemplate and crashes. These modules shouldn't interfere due to item quality for enchants, but they do.Changes Proposed:
Issues Addressed:
https://github.com/azerothcore/mod-random-enchants/issues/32SOURCE:
Here's an image where the two modules are shown working together:

at the top: item receives enchants. at the bottom: item automatically sold.
Tests Performed:
How to Test the Changes:
mod-random-enchantsandmod-junk-to-gold