Add localization support to mod_guildhouse#72
Open
Wishmaster117 wants to merge 2 commits intoazerothcore:masterfrom
Open
Add localization support to mod_guildhouse#72Wishmaster117 wants to merge 2 commits intoazerothcore:masterfrom
Wishmaster117 wants to merge 2 commits intoazerothcore:masterfrom
Conversation
This PR adds a new mod_guildhouse_locale table and a helper function to fetch guild house texts based on the player’s locale, with an automatic fallback to enUS. All user-facing hardcoded strings in mod_guildhouse (system messages, gossip options, broadcasts and commands) are now loaded from the DB, with translations provided for all WotLK locales. No gameplay logic is changed; only the text source is refactored to be consistent with AzerothCore’s localization style.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new mod_guildhouse_locale table and a helper function to fetch guild house texts based on the player’s locale, with an automatic fallback to enUS.
All user-facing hardcoded strings in mod_guildhouse (system messages, gossip options, broadcasts and commands) are now loaded from the DB, with translations provided for all WotLK locales. No gameplay logic is changed; only the text source is refactored to be consistent with AzerothCore’s localization style.