Add set -e to buildspecs with multi line commands

[davidh44]

Motivation and Context

In multi line commands, a subsequent successful command will mask a previous command that fails
Re-adding previous PR that was reverted due to integ test failures - #6524

Modifications

Add set -e to beginning of multi line commands in buildpsecs

[joviegas]

Why have we not done set -e as soon as we called | as in

      - |
        set -e
        if [ "$JAVA_VERSION" -ge "9" ]; then
          cd test/module-path-tests
          mvn package
          mvn exec:exec -P mock-tests
        fi

?

[davidh44]

The check in if clause won't throw error, we don't need set -e if its false

[joviegas]

I ran a test below

version: 0.2

phases:
  build:
    commands:
      - echo "Test with JAVA_VERSION somehow set incorrectly "
      - export JAVA_VERSION=11.232
      - |
        if [ "JAVA_VERSION" -ge "9" ]; then
          set -e
          echo "Entering the if block"
          cd /nonexistent/directory
          echo "You will not see this"
        fi
      - echo "Build succeded even when if clause failed"

And the Build succeeded even though it gave a log as below

/codebuild/output/tmp/script.sh: line 4: [: JAVA_VERSION: integer expression expected
Build succeded even when if clause failed

I think currently we are assumming the If clause will always pass , there can be issues if the condition in if itself has some typos as I gave example

Inorder to make solution applicable to all the statements after | I think we need to add set -e as soon as we call |
This will also help us to to avoid any issues if we add else part or another if in future. WDYT ?

[davidh44]

Don't think we need it, but can move it up as it is harmless. JAVA_VERSION should never be null, and we don't currently have an else clause. The set e as is will apply to both mvn commands

We'll need to add set e for each separate multiline block that we add in the future

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.