Skip to content

Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out#1095

Open
jlizen wants to merge 3 commits intoaws:mainfrom
jlizen:main
Open

Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out#1095
jlizen wants to merge 3 commits intoaws:mainfrom
jlizen:main

Conversation

@jlizen
Copy link
Collaborator

@jlizen jlizen commented Feb 5, 2026

📬 Issue #, if available:
#1065

✍️ Description of changes:

Implements option 1 as discussed here:

  • rename experimental-concurrency feature to concurrency-tokio
  • keep the run vs run_concurrent split, to make it very explicit to developers if they should reason about concurrency
  • relax run() + AWS_LAMBDA_MAX_CONCURRENCY to a warn log line on init rather than error out
    - we use tracing::warn!, unless there is no subscriber initialized, in which case we use eprintln!
  • eagerly panic if run_concurrent is used outside of a tokio runtime - previously it would panic, but only once you set AWS_LAMBDA_MAX_CONCURRENCY > 1, which might not be set in local simulations and cause pain on deployment

Other tweaks:

  • Added # Panics documentation
  • Added tokio_unstable to expected cfgs to avoidl inter warnings
  • Skip integration tests on forks
    • This has been bugging me, my CI is always red on my fork. I'll make sure it still runs when this PR is merged (since integ tests only run on push to main)

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jlizen jlizen requested review from FullyTyped and maxday and removed request for FullyTyped February 5, 2026 05:02
@jlizen jlizen marked this pull request as ready for review February 5, 2026 05:03
@jlizen jlizen force-pushed the main branch 2 times, most recently from 9db72b9 to c5cae33 Compare February 5, 2026 05:14
@jlizen jlizen requested a review from bnusunny February 5, 2026 05:57
@jlizen jlizen changed the title Refactor(lambda managed instances): Unify concurrency handling to all be under run(), which gains new bounds based on feature flag Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY a warn log line rather than error Feb 5, 2026
@jlizen jlizen force-pushed the main branch 2 times, most recently from 99c7a7c to cf10c2c Compare February 5, 2026 06:39
@jlizen jlizen changed the title Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY a warn log line rather than error Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error Feb 5, 2026
@jlizen jlizen changed the title Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out Feb 5, 2026
@jlizen jlizen changed the title Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out Refactor(lambda managed instances): rename experimental-concurrency feature -> concurrency-tokio, make run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants