Conversation
9db72b9 to
c5cae33
Compare
run(), which gains new bounds based on feature flagexperimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY a warn log line rather than error
99c7a7c to
cf10c2c
Compare
experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY a warn log line rather than errorexperimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error
experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than errorexperimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out
…MAX_CONCURRENCY, rename feature experimental-concurrency -> concurrency->tokio
…since they require creds
experimental-concurrency feature -> concurrency-tokio, make it run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error outexperimental-concurrency feature -> concurrency-tokio, make run() + AWS_LAMBDA_MAX_CONCURRENCY add a warn log line rather than error out
FullyTyped
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
#1065
✍️ Description of changes:
Implements option 1 as discussed here:
experimental-concurrencyfeature toconcurrency-tokiorunvsrun_concurrentsplit, to make it very explicit to developers if they should reason about concurrencyrun()+AWS_LAMBDA_MAX_CONCURRENCYto a warn log line on init rather than error out- we use
tracing::warn!, unless there is no subscriber initialized, in which case we useeprintln!run_concurrentis used outside of a tokio runtime - previously it would panic, but only once you setAWS_LAMBDA_MAX_CONCURRENCY > 1, which might not be set in local simulations and cause pain on deploymentOther tweaks:
main)🔏 By submitting this pull request