Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2025

Bumps awscrt from 0.27.6 to 0.28.1.

Also exposes new CRT S3 client parameters to control file IO: should_stream, disk_throughput, and direct_io via the shared config file. https://github.com/awslabs/aws-crt-python/blob/e6a48db2b9c16288af5ae0b8bd5269eb9d3c3c02/awscrt/s3.py#L146-L179

Preview of docs for new s3 configs:
image
image
image

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies This issue is a problem in a dependency. v2 labels Sep 19, 2025
@hssyoo hssyoo force-pushed the dependabot/pip/v2/awscrt-0.28.1 branch from 3bc78a0 to 7eea2ff Compare September 19, 2025 17:42
@hssyoo hssyoo self-assigned this Sep 19, 2025
dependabot bot and others added 7 commits September 23, 2025 14:33
Bumps [awscrt](https://github.com/awslabs/aws-crt-python) from 0.27.6 to 0.28.1.
- [Release notes](https://github.com/awslabs/aws-crt-python/releases)
- [Commits](awslabs/aws-crt-python@v0.27.6...v0.28.1)

---
updated-dependencies:
- dependency-name: awscrt
  dependency-version: 0.28.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@hssyoo hssyoo force-pushed the dependabot/pip/v2/awscrt-0.28.1 branch from 845a73e to eb02eea Compare September 23, 2025 18:34
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments/questions

**Default** - ``10.0``

The estimated target disk throughput. This value is only applied if
``should_stream`` is set to ``true``.This value can be specified using
Copy link
Contributor

@AndrewAsseily AndrewAsseily Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: There's a missing space after true.

Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor nit and hit retry on the failing CI test, but LGTM to me assuming that passes.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2025

A newer version of awscrt exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@hssyoo
Copy link
Contributor

hssyoo commented Nov 5, 2025

I'm closing this PR to break it out into 2 separate PRs that will be released independently: 1 for bumping to latest version and 1 for exposing CRT file io options

@hssyoo hssyoo closed this Nov 5, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/v2/awscrt-0.28.1 branch November 5, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies This issue is a problem in a dependency. v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants