This repository was archived by the owner on May 31, 2024. It is now read-only.
fix: temporary MANIFEST.json is created and combined with file path from --inputsFile#527
Open
fix: temporary MANIFEST.json is created and combined with file path from --inputsFile#527
Conversation
added 6 commits
September 27, 2022 10:21
lingjiekong
reviewed
Oct 11, 2022
lingjiekong
reviewed
Oct 11, 2022
lingjiekong
reviewed
Oct 11, 2022
lingjiekong
reviewed
Oct 13, 2022
lingjiekong
reviewed
Oct 17, 2022
lingjiekong
reviewed
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 474
Description of Changes
added new function
parseAndAddToManifest()that allows users to use a MANIFEST.json file and include a file with the --inputsFile flag without any overriding.Description of how you validated changes
Various calls of
makeandworkflow runwere used to test creation of new file, as well as its eventual deletion.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license