Skip to content

Fix: Close inter-use-case demo popup when navigating away #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hide-G wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −17
Open

Fix: Close inter-use-case demo popup when navigating away #1355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions packages/web/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,12 @@ const inlineAgents: boolean = import.meta.env.VITE_APP_INLINE_AGENTS === 'true';
const mcpEnabled: boolean = import.meta.env.VITE_APP_MCP_ENABLED === 'true';
const agentCoreEnabled: boolean =
import.meta.env.VITE_APP_AGENT_CORE_ENABLED === 'true';
const agentBuilderEnabled: boolean =
import.meta.env.VITE_APP_AGENT_CORE_AGENT_BUILDER_ENABLED === 'true';

const {
visionEnabled,
imageGenModelIds,
videoGenModelIds,
speechToSpeechModelIds,
agents,
agentNames,
flowChatEnabled,
} = MODELS;

Expand Down Expand Up @@ -123,10 +120,10 @@ const App: React.FC = () => {
}
: null,
...(agentEnabled && inlineAgents
? agents.map((agent) => {
? agentNames.map((name: string) => {
return {
label: agent.displayName,
to: `/agent/${agent.displayName}`,
label: name,
to: `/agent/${name}`,
icon: <PiRobot />,
display: 'usecase' as const,
sub: 'Agent',
Expand All @@ -151,15 +148,6 @@ const App: React.FC = () => {
sub: 'Experimental',
}
: null,
agentBuilderEnabled
? {
label: 'Agent Builder',
to: '/agent-builder',
icon: <PiRobot />,
display: 'usecase' as const,
sub: 'Experimental',
}
: null,
flowChatEnabled
? {
label: t('navigation.flowChat'),
Expand Down Expand Up @@ -290,6 +278,25 @@ const App: React.FC = () => {
}
}, [pathname, screen, notifyScreen]);

// Close inter-use-cases demo popup when navigating away from demo pages
const { setIsShow: setInterUseCasesShow, useCases } = useInterUseCases();
useEffect(() => {
// Only check if demo is currently shown and useCases are loaded
// Skip if useCases is empty to avoid closing during initialization
if (isShow && useCases.length > 0) {
const isInDemoFlow = useCases.some((useCase) => {
// Normalize paths by ensuring they start with /
const useCasePath = useCase.path.startsWith('/') ? useCase.path : `/${useCase.path}`;
// Check if current path matches any use case path
return pathname === useCasePath || pathname.startsWith(useCasePath + '/');
});
if (!isInDemoFlow) {
setInterUseCasesShow(false);
}
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [pathname, isShow]);

return (
<div
className="screen:w-screen screen:h-screen overflow-x-hidden overflow-y-scroll"
Expand All @@ -307,7 +314,7 @@ const App: React.FC = () => {
</button>
</div>

{label}
{pathname !== '/' ? label : ''}

{/* Dummy block to center the label */}
<div className="w-10" />
Expand Down