feat: add integration tests for ACK runtime reconciler #223
Conversation
Add integration tests that verify the core reconciliation lifecycle using the envtest framework with a fake AWS resource manager. Inspired by kro's testing approach, the tests validate CREATE, UPDATE, and DELETE operations, asserting precise API call counts and operation sequences. This follows the same patterns used by real ACK controllers like s3-controller, using BindControllerManager to wire up the reconciler properly. The test infrastructure includes a fake DynamoDB Table resource with realistic fields (ProvisionedThroughput, SSESpecification, Tags, etc.) and a delta comparison implementation matching the code-generated patterns in ACK controllers. This provides a foundation for testing runtime behavior changes without requiring actual AWS API calls or a real controller codebase.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1 participant
Add integration tests that verify the core reconciliation lifecycle using the
envtest framework with a fake AWS resource manager. Inspired by kro's testing
approach, the tests validate CREATE, UPDATE, and DELETE operations, asserting
precise API call counts and operation sequences. This follows the same patterns
used by real ACK controllers like s3-controller, using BindControllerManager to
wire up the reconciler properly.
The test infrastructure includes a fake DynamoDB Table resource with realistic
fields (ProvisionedThroughput, SSESpecification, Tags, etc.) and a delta
comparison implementation matching the code-generated patterns in ACK
controllers. This provides a foundation for testing runtime behavior changes
without requiring actual AWS API calls or a real controller codebase.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.