Skip to content

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Dec 10, 2025

Issue #2695 && #2622

Description of changes:
Some spec fields get default values from AWS after they are created.
These defaults cause the controller to keep requeuing, trying to set
them to null. With these changes, we late initialize these fields,
ensuring they are defaulted if the user does not define them

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler December 10, 2025 19:34
@ack-prow ack-prow bot added the approved label Dec 10, 2025
@michaelhtm michaelhtm force-pushed the fix/dbinstancedelta branch 2 times, most recently from 4ba44d4 to 1724a63 Compare December 10, 2025 20:19
@michaelhtm michaelhtm changed the title ignore delta of fields that get defaulted by AWS late initialize fields that get defaulted by AWS Dec 10, 2025
@ack-prow
Copy link

ack-prow bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… AWS

Some spec fields get default values from AWS after they are created.
These defaults cause the controller to keep requeuing, trying to set
them to null. With these changes, we late initialize these fields,
ensuring they are defaulted if the user does not define them
@ack-prow
Copy link

ack-prow bot commented Dec 12, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rds-verify-code-gen 5f602da link false /test rds-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants