Skip to content

Feat/add servicemonitor and prometheusrule #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oded-dd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat/add servicemonitor and prometheusrule #254

oded-dd wants to merge 2 commits into from

Conversation

@oded-dd
Copy link

@oded-dd oded-dd commented Dec 3, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@oded-dd
feat(helm): add ServiceMonitor and PrometheusRule support
f1292ca 
- Add serviceMonitor configuration to values.yaml with interval and scrapeTimeout options
- Add prometheusRule configuration with RDSControllerSyncErrors alert (severity: critical)
- Create service-monitor.yaml template for Prometheus Operator ServiceMonitor
- Create prometheus-rule.yaml template for Prometheus Operator PrometheusRule
- Update values.schema.json with schema definitions for new options
@oded-dd
fix(helm): correct job label in PrometheusRule alert expression
8010ab5 
The alert expression was referencing job='rds-controller-controller-metrics'
but the ServiceMonitor generates job='rds-controller-metrics'. Fixed the
mismatch so the alert will correctly match scraped metrics.
@ack-prow ack-prow bot requested review from knottnt and michaelhtm December 3, 2025 11:03
@ack-prow
Copy link

ack-prow bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oded-dd
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2025
@ack-prow
Copy link

ack-prow bot commented Dec 3, 2025

Hi @oded-dd. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oded-dd
Copy link
Author

oded-dd commented Dec 8, 2025

Hey. Any update on that?

@oded-dd oded-dd mentioned this pull request Dec 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knottnt knottnt Awaiting requested review from knottnt

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oded-dd