Skip to content

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Dec 11, 2025

Issue #2684

Description of changes:
With these changes, we allow users to use ClusterName, Namespace, and
ServiceAccount to adopt a PodIdentityAssociation resource when using
adopt-or-create if AssociationID is not provided.

Note: this will not work when using adopt adoption policy

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

With these changes, we allow users to use ClusterName, Namespace, and
ServiceAccount to adopt a PodIdentityAssociation resource when using
`adopt-or-create`
@ack-prow
Copy link

ack-prow bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler December 11, 2025 22:39
@ack-prow ack-prow bot added the approved label Dec 11, 2025
@ack-prow
Copy link

ack-prow bot commented Dec 11, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-verify-code-gen f116109 link false /test eks-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant