Open
Conversation
This extra bit of information is useful in the context of telemetry, specifically OpenTelemetry, as it allow us to adhere to [Semantic Attributes for AWS][1]. To reduce coordination efforts, this change will only affect aws-elixir. A further patch can address aws-erlang to achieve parity. [1]: https://github.com/open-telemetry/opentelemetry-specification/blob/0a4c6656d1ac1261cfe426b964fd63b1c302877d/specification/trace/semantic_conventions/instrumentation/aws-sdk.md
Author
|
Worth noting this PR is a bit old, done when ServiceMetadata struct was a thing. Given metadata is now just a plain Map, an alternative is to include the |
Member
|
@andrewhr Sorry to dig this up as this seems to have fallen between chairs. Any chance you can rebase and pick this up so we can get it back into a mergeable state? 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extra bit of information is useful in the context of telemetry, specifically OpenTelemetry, as it allow us to adhere to Semantic Attributes for AWS.
To reduce coordination efforts, this change will only affect aws-elixir. A further patch can address aws-erlang to achieve parity.