Skip to content

Conversation

sebaland
Copy link
Contributor

@sebaland sebaland commented Apr 24, 2024

Description of changes:
This PR adds the release_authenticator.yml and release_kickoff.yml workflows automating the Release process.
Also adding the corresponding Fastlane files.

This is their behaviour:

  • Kickoff release: Is manually triggered through the Actions tab and takes care of updating the changelog, updating the ComponentInformation and creating a PR into main with these changes for the maintainer to review and merge
  • Release Authenticator: Is automatically triggered on any push to main. When the commit is a result of the previous kickoff PR being merged, a stable releases is performed; all other commits result in an unstable release.
    • Stable release: Follows SIMVER and is either a major, minor or patch release
    • Unstable: a.k.a. pre-release. It basically just contains the latest in main with a tag with format X.Y.Z.unstable.i, with X.Y.Z being the next tentative version and i the current iteration of unstable releases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sebaland sebaland requested review from a team as code owners April 24, 2024 18:32
harsh62
harsh62 previously approved these changes Apr 24, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.89%. Comparing base (a98f1c6) to head (a562e5f).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   41.89%   41.89%           
=======================================
  Files          41       41           
  Lines        1857     1857           
=======================================
  Hits          778      778           
  Misses       1079     1079           
Flag Coverage Δ
Authenticator 41.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebaland sebaland deployed to Release May 15, 2024 21:15 — with GitHub Actions Active
@sebaland sebaland marked this pull request as draft May 15, 2024 21:16
…d instead kicking off the release by merging into main
@sebaland sebaland marked this pull request as ready for review May 16, 2024 15:37
Comment on lines +18 to +24
run: |
if ${{ github.event.head_commit.author.username == 'github-actions[bot]' && startsWith(github.event.head_commit.message, 'chore: Release ') }}; then
VALUE=stable
else
VALUE=unstable
fi
echo "value=$VALUE" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an action instead of an inline script (recommended). For more information visit https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#good-practices-for-mitigating-script-injection-attacks

Event context data that are user controlled must be treated as potentially untrusted input. For more information visit https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections

Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security risk needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants