Maintenance work for the main GitHub Action workflow#4103
Open
Aire-One wants to merge 4 commits into
Open
Conversation
main GitHub Action workflow
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4103 +/- ##
==========================================
- Coverage 90.42% 90.41% -0.01%
==========================================
Files 940 940
Lines 60290 60289 -1
Branches 1139 1139
==========================================
- Hits 54516 54510 -6
- Misses 5268 5271 +3
- Partials 506 508 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a maintenance work for our main workflow. It aims at standardizing the Actions usages, which simplify a lot the workflow, and will also unblock easier support for Lua55.
The main change is the switch to use Actions
leafo/gh-actions-luaandleafo/gh-actions-luarocksto respectively install Lua and Luarocks. I have already introduced theluarocks/gh-actions-luaa few times ago to manage LuaJIT, this work extends its usage for all the Lua versions we test. I switched from theluarocksfork back to theleafoupstream because it got updated and is now the more up-to-date version.This PR also cleans the
envand removes themanual_screensforlua5.4because I'm not sure what is the additional value it brings over thecodecov-lua5.3.