Skip to content

chore(awesomerc): use the group attribute to reduce boilerplate code#4097

Open
cnjhb wants to merge 1 commit into
awesomeWM:masterfrom
cnjhb:rc
Open

chore(awesomerc): use the group attribute to reduce boilerplate code#4097
cnjhb wants to merge 1 commit into
awesomeWM:masterfrom
cnjhb:rc

Conversation

@cnjhb

@cnjhb cnjhb commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

The last group for awful.key used to be layout, but setting it to tag works just fine, since it modifies the layout of the selected tag. It’s actually still related to the tag.

@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (4960086) to head (de5e225).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4097      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.01%     
==========================================
  Files         941      941              
  Lines       60391    60391              
  Branches     1145     1145              
==========================================
+ Hits        54638    54648      +10     
+ Misses       5246     5234      -12     
- Partials      507      509       +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@actionless

Copy link
Copy Markdown
Member

setting it to tag works just fine, since it modifies the layout of the selected tag. It’s actually still related to the tag.

no, there are more hotkeys which do other layout-related stuff, so that looks not logical assigning one of them randomly to another group

@cnjhb

cnjhb commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

setting it to tag works just fine, since it modifies the layout of the selected tag. It’s actually still related to the tag.

no, there are more hotkeys which do other layout-related stuff, so that looks not logical assigning one of them randomly to another group

It's been changed back now.

Comment thread awesomerc.lua
{ description = "select layout directly", group = "layout" })
})

-- @DOC_NUMBER_KEYBINDINGS@

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now your change conflicts with this docstring

Comment thread awesomerc.lua
end
end,
{ description = "select layout directly", group = "layout" })
})

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why this one moved (?)

Also, our pattern is to move toward named parameter as much as possible, so having a function style now is like going backward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants