[doc] fix(ldoc.ltp): extra-header tag arrangement#3318
Merged
Elv13 merged 1 commit intoApr 5, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3318 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 702 702
Lines 46668 46668
=======================================
+ Hits 41377 41378 +1
+ Misses 5291 5290 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Elv13
approved these changes
Apr 5, 2021
sclu1034
added a commit
to sclu1034/awesome
that referenced
this pull request
Apr 17, 2021
* master: (77 commits) debug: Print *why* the build fails. doc(wibox.widget.textclock): Widget definition. fix(ldoc.ltp): extra-header tag arrangement (awesomeWM#3318) doc: Revert the last few commits. (awesomeWM#3317) Debug doc issue (awesomeWM#3316) doc: More debug messages (awesomeWM#3315) doc: Debug an issue where the documentation isn't generated properly (awesomeWM#3314) doc(layout.flex): Hide `fill_space` property doc doc(ltp): Implement module `extra-header` section Add more @supermodule and @hidden fix(ldoc.ltp): item.inherited can be wrongly true doc(imagebox): Fix @method tags doc(@hidden): Add to wibox.widget.base module doc(@hidden;ldoc.ltp): Add ldoc tag to hide item doc(@supermodule): Add to awful.widget modules doc(@supermodule): Add to wibox.layout modules doc(@supermodule): Add to wibox.container modules doc(@supermodule): Add to wibox.widget modules fix(ldoc.ltp): Identify inherited items by name fix(ldoc.ltp): item.inherited can be wrongly false ... Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
actionless
pushed a commit
to actionless/awesome
that referenced
this pull request
Apr 26, 2021
man9ourah
pushed a commit
to man9ourah/awesome
that referenced
this pull request
Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix the tag arrangement issue @Elv13 spotted following the merge of #3288.
As a side note, there is a block line 225-227 (after applying this patch):
I don't know what it is used for, I can't find an instance of
@includein our codebase, and it seems this if statement is always evaluated tofalse(I tried to force the print ofmodule.tags.include, and it was always empty).@blueyed, git blame says you added these lines (6792415), what are this supposed to be used for? Should we move this block to a
extra-header__sectionblock?