Skip to content

[doc] fix(ldoc.ltp): extra-header tag arrangement#3318

Merged
Elv13 merged 1 commit into
awesomeWM:masterfrom
Aire-One:fix/ldoc-ltp-extra-header-tag-arrangement
Apr 5, 2021
Merged

[doc] fix(ldoc.ltp): extra-header tag arrangement#3318
Elv13 merged 1 commit into
awesomeWM:masterfrom
Aire-One:fix/ldoc-ltp-extra-header-tag-arrangement

Conversation

@Aire-One

@Aire-One Aire-One commented Apr 5, 2021

Copy link
Copy Markdown
Member

This fix the tag arrangement issue @Elv13 spotted following the merge of #3288.

As a side note, there is a block line 225-227 (after applying this patch):

#   if module.tags.include then
        $(M(ldoc.include_file(module.tags.include)))
#   end

I don't know what it is used for, I can't find an instance of @include in our codebase, and it seems this if statement is always evaluated to false (I tried to force the print of module.tags.include, and it was always empty).

@blueyed, git blame says you added these lines (6792415), what are this supposed to be used for? Should we move this block to a extra-header__section block?

@codecov

codecov Bot commented Apr 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3318 (ba97397) into master (022be39) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3318   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         702      702           
  Lines       46668    46668           
=======================================
+ Hits        41377    41378    +1     
+ Misses       5291     5290    -1     
Flag Coverage Δ
gcov 75.24% <ø> (ø)
luacov 91.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/awful/widget/layoutlist.lua 91.44% <0.00%> (+0.65%) ⬆️

@Elv13 Elv13 merged commit 9807ccd into awesomeWM:master Apr 5, 2021
sclu1034 added a commit to sclu1034/awesome that referenced this pull request Apr 17, 2021
* master: (77 commits)
  debug: Print *why* the build fails.
  doc(wibox.widget.textclock): Widget definition.
  fix(ldoc.ltp): extra-header tag arrangement (awesomeWM#3318)
  doc: Revert the last few commits. (awesomeWM#3317)
  Debug doc issue (awesomeWM#3316)
  doc: More debug messages (awesomeWM#3315)
  doc: Debug an issue where the documentation isn't generated properly (awesomeWM#3314)
  doc(layout.flex): Hide `fill_space` property doc
  doc(ltp): Implement module `extra-header` section
  Add more @supermodule and @hidden
  fix(ldoc.ltp): item.inherited can be wrongly true
  doc(imagebox): Fix @method tags
  doc(@hidden): Add to wibox.widget.base module
  doc(@hidden;ldoc.ltp): Add ldoc tag to hide item
  doc(@supermodule): Add to awful.widget modules
  doc(@supermodule): Add to wibox.layout modules
  doc(@supermodule): Add to wibox.container modules
  doc(@supermodule): Add to wibox.widget modules
  fix(ldoc.ltp): Identify inherited items by name
  fix(ldoc.ltp): item.inherited can be wrongly false
  ...

Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
actionless pushed a commit to actionless/awesome that referenced this pull request Apr 26, 2021
man9ourah pushed a commit to man9ourah/awesome that referenced this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants