Added support for 6 digit displays with digit remapping#85
Added support for 6 digit displays with digit remapping#85BleuLlama wants to merge 1 commit intoavishorp:masterfrom
Conversation
|
@avishorp |
|
By "segment data" -- do you mean the digit ordering/remapping? My thought was that someone might want to use a different remapping? But you're right; being that the only two displays that people here seem to use are the 4 digit display which works "out of the box" and the 6 digit with its odd remapping, i can rework it to include that remapping as a default. (sidenote, i also now have a "print text" function that I use in mine with a nearly-full font of sorts to print arbitrary text to the display... I'll submit a push request for that soon... pics of it on my twitter https://twitter.com/yorgle ) |
I've written a comment here for the author @avishorp of this library, not a comment for you. I'm sorry it's complicated. |
|
Actually, my code doesn't keep the remapping data in the class, just a pointer to the ordering array, and it's optional at that. If you initialize 6 of these they can all point at the same array without duplication of the array etc. But i understand your question/concern now. I can make any changes needed to make my updated functionality fit better with the goals of the main author, if so desired. |
|
Is anything happening with this PR? I just tried it after failing to get a Robotdyn 6 digit display working with the base version and it works perfectly. |
I added support for 6 digit displays, as well as remapping the order of the digits themselves. (The controller chip can support up to 6 digits.)
I did it by adding optional parameters on the constructor. With no changes, the original 4-digit behavior is preserved.
I added a 6 digit example that shows the remapping.
Some of the functions don't seem to work properly now, but everything else works great.