Skip to content

Conversation

@andponlin
Copy link
Contributor

This PR only implements for the JEX server option; I have not done this for the other server options. I tried to write a unit test for this, but it is quite difficulty with the visibility of types and methods.

@SentryMan
Copy link
Collaborator

neat, thanks for taking the time to submit a pr

@SentryMan SentryMan requested a review from rbygrave November 22, 2025 23:37
@SentryMan
Copy link
Collaborator

I tried to write a unit test for this, but it is quite difficulty with the visibility of types and methods.

you could try to write a test in the test-jex section. did that not work?

@SentryMan SentryMan self-assigned this Nov 22, 2025
@SentryMan SentryMan added the enhancement New feature or request label Nov 22, 2025
@SentryMan SentryMan added this to the 3.6 milestone Nov 22, 2025
@SentryMan SentryMan assigned andponlin and unassigned SentryMan Nov 22, 2025
@andponlin
Copy link
Contributor Author

you could try to write a test in the test-jex section. did that not work?

I started to write a unit test, but the mocking was very difficult and it was quite dependent on statically initialized types. I just noticed the test module so will TAL a the options to implement a test there.

@SentryMan SentryMan enabled auto-merge (squash) November 23, 2025 03:59
@andponlin
Copy link
Contributor Author

I will progress this further once this PR is resolved and new version of avaje-jex is released so I can bump the version on this library.

This commit only implements for the JEX server option.
Add a test

# Conflicts:
#	tests/test-jex/src/main/resources/public/openapi.json
auto-merge was automatically disabled November 25, 2025 09:07

Head branch was pushed to by a user without write access

@andponlin andponlin force-pushed the andponlin-streaming-output-1 branch from 725fc53 to 3586a17 Compare November 25, 2025 09:07
@andponlin
Copy link
Contributor Author

you could try to write a test in the test-jex section. did that not work?

That's done now. It has re-generated a number of OpenAPI specs, but it does this on master HEAD as well; is this expected / OK?

andponlin and others added 2 commits November 26, 2025 23:42
Swich back to the 3.3 of the avaje-jex and closing the `OutputStream` instead of flushing.
@SentryMan SentryMan merged commit 33c1c29 into avaje:master Nov 26, 2025
5 checks passed
@andponlin
Copy link
Contributor Author

Hi @SentryMan / @rob-bygrave 👋 -- sorry to be a pain, but is it possible to get a release of it?

@SentryMan
Copy link
Collaborator

let's get #679 merged first so we can do it all together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants