-
Notifications
You must be signed in to change notification settings - Fork 16
Support for Jax-RS style "StreamingOutput" for JEX #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Jax-RS style "StreamingOutput" for JEX #674
Conversation
|
neat, thanks for taking the time to submit a pr |
you could try to write a test in the test-jex section. did that not work? |
I started to write a unit test, but the mocking was very difficult and it was quite dependent on statically initialized types. I just noticed the |
|
I will progress this further once this PR is resolved and new version of |
This commit only implements for the JEX server option.
Add a test # Conflicts: # tests/test-jex/src/main/resources/public/openapi.json
Head branch was pushed to by a user without write access
725fc53 to
3586a17
Compare
That's done now. It has re-generated a number of OpenAPI specs, but it does this on |
http-generator-jex/src/main/java/io/avaje/http/generator/jex/ControllerMethodWriter.java
Outdated
Show resolved
Hide resolved
Swich back to the 3.3 of the avaje-jex and closing the `OutputStream` instead of flushing.
|
Hi @SentryMan / @rob-bygrave 👋 -- sorry to be a pain, but is it possible to get a release of it? |
|
let's get #679 merged first so we can do it all together |
This PR only implements for the JEX server option; I have not done this for the other server options. I tried to write a unit test for this, but it is quite difficulty with the visibility of types and methods.