Skip to content

Conversation

@geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Dec 3, 2025

Why this should be merged

Updates solc to v0.8.30.

How this works

The compiler complains about pragma solidity ^0.8.25 not matching semver requirements. This is fixed by changing to pragma solidity ^0.8.25.0 - I think because the actual versions include patches.

How this was tested

I confirmed the change does not let the contracts compile with solidity v0.8.24

How is this documented

@geoff-vball geoff-vball marked this pull request as ready for review December 3, 2025 15:38
@geoff-vball geoff-vball requested a review from a team as a code owner December 3, 2025 15:38
@iansuvak
Copy link
Contributor

iansuvak commented Dec 3, 2025

Why are we not switching pragmas to 0.8.30 directly? IMO there is benefit in a specific tag/commit being guaranteed to have been compiled/tested/audited against a specific version.

@batconjurer
Copy link
Contributor

Why are we not switching pragmas to 0.8.30 directly? IMO there is benefit in a specific tag/commit being guaranteed to have been compiled/tested/audited against a specific version.

I would second this

@geoff-vball geoff-vball merged commit 1320f95 into main Dec 5, 2025
22 checks passed
@geoff-vball geoff-vball deleted the update-solc branch December 5, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants