Improve client test coverage #1024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylg-avalabs
requested review from
batconjurer,
bernard-avalabs,
geoff-vball,
iansuvak,
mdelle1 and
michaelkaplan13
geoff-vball
reviewed
Nov 17, 2025
peers/proposervm_client_test.go
Outdated
Comment on lines
138
to
139
| // TestProposerVMAPI_CombinedQueryParamsAndHeaders verifies both work together | ||
| func TestProposerVMAPI_CombinedQueryParamsAndHeaders(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Is there a way that headers and query params interact that we need to test them together?
geoff-vball
reviewed
Nov 17, 2025
geoff-vball
reviewed
Nov 25, 2025
geoff-vball
reviewed
Dec 4, 2025
Contributor
geoff-vball
left a comment
geoff-vball
left a comment
There was a problem hiding this comment.
Just a few nits. They should also be applied to the other test in the file. Otherwise lgtm :)
Comment on lines
+457
to
+458
| logger := logging.NoLog{} | ||
| _, err := NewDestinationClient(logger, &destinationBlockchain, time.Minute) |
Contributor
There was a problem hiding this comment.
We should just inline short declarations that are only used once.
Suggested change
| logger := logging.NoLog{} | |
| _, err := NewDestinationClient(logger, &destinationBlockchain, time.Minute) | |
| _, err := NewDestinationClient(logging.NoLog{}, &destinationBlockchain, time.Minute) |
| client, err := NewDestinationClient(logger, &destinationBlockchain, time.Minute) | ||
| require.NoError(t, err) | ||
|
|
||
| ctx := context.Background() |
Contributor
There was a problem hiding this comment.
Suggested change
| ctx := context.Background() | |
| ctx := t.Context() |
Comment on lines
+526
to
+527
| mu.Lock() | ||
| defer mu.Unlock() |
Contributor
There was a problem hiding this comment.
I think this mutex is just ensuring that the handler func has finished running? But ethClient.SuggestGasTipCap(ctx) won't finish until the handlerfunc is finished, so I don't think we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented