This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Bat/receive icm on ethereum poc #893
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
requested review from
geoff-vball,
iansuvak,
mdelle1,
michaelkaplan13 and
ylg-avalabs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Semgrep PRO found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
geoff-vball
reviewed
Dec 2, 2025
Comment on lines
+8
to
+10
| [submodule "ethereum/lib/forge-std"] | ||
| path = ethereum/lib/forge-std | ||
| url = https://github.com/foundry-rs/forge-std |
Contributor
There was a problem hiding this comment.
You shouldn't need an extra submodule for this on the eth side. You should be able to set remappings.txt to resolve to whatever you need it to in order to use the already existing submodule.
| src = "contracts" | ||
| out = "out" | ||
| libs = ["lib"] | ||
| solc_version = '0.8.30' |
Contributor
There was a problem hiding this comment.
Do we need a newer version of solc for the ethereum BLS libraries?
Contributor
Author
There was a problem hiding this comment.
yes. I would love if it if we used a consistent solc version everywhere. Is there any good reason we can't?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented