(coreth) Write block header/body/receipts on Accept #4644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #4628.
This PR defers writing block header/body/receipts from verify/insert to Accept. Instead of persisting blocks immediately upon verification, verified blocks are cached in memory and only written to disk when accepted.
This is needed for coreth to use
blockdbbefore SAE. We should merge this if we want to enable blockdb before SAE is released.How this works
This change means verified but not accepted blocks are no longer persisted to disk. If a blockchain crashes before a verified block is accepted, the block will be lost from memory but can be bootstrapped from the network.
How this was tested