refactor(reexecute/c): export CreateBlockChanFromLevelDB #4638
+98
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As part of switching from using
go benchto custom benchmarks in the reexecution tests (#4508), we'll need to exportCreateBlockChanFromLevelDB()so that the reexecution test and the export block range tool can use this (as they'll be living in separate packages as executables).This PR is a precursor to #4639.
How this works
Moves
CreateBlockChanFromLevelDB()andBlockKey()to thereexecutepackage so that it's accessible to both the reexecution test and the export block range test.How this was tested
CI + ran
task export-cchain-block-rangelocallyNeed to be documented in RELEASES.md?
No