feat: Add Avalanche Local chain support and fix HRP for local networks #316
+35
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenwahlgren
requested review from
a team,
SayanKar and
rajranjan0608
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
owenwahlgren
force-pushed
the
feat/add-avalanche-local-chain
branch
from
6807b64 to
22067fd
Compare
SayanKar
approved these changes
Dec 11, 2025
The SDK was incorrectly using the chain.testnet flag to determine HRP, which mapped testnet=true to "fuji" and testnet=false to "avax". This caused local networks (network ID 12345) to incorrectly use "fuji" HRP instead of "local" HRP. The fix: - Always query the actual network ID from the node via getContextFromURI - Use getHRP(networkId) to map network ID to correct HRP - This properly supports all network IDs: mainnet (1), fuji (5), local (12345), etc. Affected files: - signXPTransaction.ts: Core signing/sending logic - transferCtoPChain.ts: C-Chain to P-Chain transfers - transferPtoCChain.ts: P-Chain to C-Chain transfers - transferPtoPChain.ts: P-Chain to P-Chain transfers 🔺 Generated by DevRel swarm
The SDK had LOCAL_NETWORK_ID = 1337 but avalanchejs and tmpnet use network ID 12345 for local networks. This inconsistency could cause issues when using the exported constants. 🔺 Generated by DevRel swarm
owenwahlgren
force-pushed
the
feat/add-avalanche-local-chain
branch
from
22067fd to
5e80966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
avalancheLocalchain definition for local/tmpnet developmentsignXPTransactionto query the actual network ID from the node instead of relying onchain.testnetflagLOCAL_NETWORK_IDconstant from 1337 to 12345 to match avalanchejs and tmpnetProblem
When using the SDK with local networks (tmpnet), transactions failed with:
The root cause was:
signXPTransactioncheckedclient.chain?.testnetand if true, assumed network ID 5 (Fuji)isTestnet ? "fuji" : "avax"for HRP, never supporting "local"Solution
getContextFromURI()getHRP(networkId)which properly maps network IDs to HRP strings including "local" for 12345LOCAL_NETWORK_IDconstant to 12345 for consistency with avalanchejsTest plan