Fix loopback option to be sender only#66
Merged
JWhitleyWork merged 2 commits intoJan 21, 2026
Conversation
Signed-off-by: Kevin Hallenbeck <khallenbeck@dataspeedinc.com>
Revert most of e39a814 Signed-off-by: Kevin Hallenbeck <khallenbeck@dataspeedinc.com>
khallenbeck-dsi
force-pushed
the
sender_loopback
branch
from
8e66a32 to
0fdbbce
Compare
This was referenced Jan 15, 2026
Member
|
@JWhitleyWork friendly ping :) |
TetsuKawa
pushed a commit
to TetsuKawa/ros2_socketcan
that referenced
this pull request
Mar 18, 2026
* Add loopback option to sender Signed-off-by: Kevin Hallenbeck <khallenbeck@dataspeedinc.com> * Remove loopback option from receiver Revert most of e39a814 Signed-off-by: Kevin Hallenbeck <khallenbeck@dataspeedinc.com> --------- Signed-off-by: Kevin Hallenbeck <khallenbeck@dataspeedinc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loopback option added in #45 is functionally hard-coded to false. It was added to the common code with a default of false, and exposed as a parameter and launch argument on the receiver. However, the sender is the one that selects if the transmitted message loops back and shows up on the receiver. The loopback option on the receiver has no effect.
This PR moves the loopback option from the receiver to the sender.