AdobeReader.munki: force munki version via --pkgvers (new installer filename breaks version detection) - #564
Open
mikeknight85 wants to merge 1 commit into
Open
Conversation
Adobe renamed the installer from AcroRdrDC_<version>_MUI.dmg to AdobeReader<version>.dmg (e.g. AdobeReader2600121662.dmg). With the new name, makepkginfo's name/version heuristic splits the trailing digits off the pkg name and the imported pkginfo gets version "2600121662" instead of "26.001.21662". Since munki compares that as a single huge number, such an item sorts above every future 26.x/27.x release and blocks all further updates. Pass the properly dotted version from AdobeReaderURLProvider to makepkginfo via --pkgvers so the pkginfo version always matches the actual release version.
mikeknight85
pushed a commit
to SRGSSR/recipes
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adobe renamed the Reader installer from
AcroRdrDC_<version>_MUI.dmgtoAdobeReader<version>.dmg(current:AdobeReader2600121662.dmg).With the new naming,
makepkginfo's name/version heuristic splits the trailing digits off the pkg name, so the imported pkginfo getsversion: 2600121662instead of26.001.21662. The receipts keep the dotted versions (the Distribution has no product version attribute), but the item version is wrong.This is worse than cosmetic: munki's version comparison treats
2600121662as a single huge number, so this item sorts above every future 26.x/27.x release — clients stick to it and never see another Reader update.Repro:
Fix: pass the properly dotted version that
AdobeReaderURLProvideralready returns (from Adobe's RDC API, e.g.26.001.21662) to makepkginfo viaadditional_makepkginfo_options --pkgvers. Older installers with the previous naming are unaffected by this change — the explicit version matches what the heuristic used to fall back to.