fix(samples): build against source via ProjectReference (removes release race)#5
Merged
Merged
Conversation
anthony-keller
approved these changes
Jun 23, 2026
…lished package The samples consumed EntityFrameworkCore.Triggered via PackageReference, which (a) can't restore a new version line until it's published — a release race — and (b) pointed at the upstream package id, not the fork's AutoGuru.* packages, so they could never resolve the fork's versions regardless (red since the rename). Switch all four samples to ProjectReference against the in-repo src projects: they now build against current source every commit, no publish dependency, no race. The `build` (full .sln) and `build-samples` jobs both go green from source; release.yml is unaffected (already packs Core.slnf).
benmccallum
force-pushed
the
fix/ci-build-core-slnf
branch
from
c574a62 to
37af986
Compare
benmccallum
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainCI has been red since the AutoGuru rename. The sample projects consume the library viaPackageReferenceto the upstreamEntityFrameworkCore.Triggeredpackage id (not the fork'sAutoGuru.*packages), pinned to the current major. Sodotnet restorefailsNU1102— and because thebuildjob restores the full.sln(which includes samples), the library was never actually compiled or tested in CI.It's also an inherent release race: a brand-new version line can't be sample-built until it's published, but you'd want to validate before publishing.
Fix
Switch all four samples from
PackageReferencetoProjectReferenceagainst the in-reposrc/projects. Samples now build against current source on every commit — no published-package dependency, no race, andbuild-samplesbecomes a real gate again.Trade-off: samples no longer exercise the packaged artifact (which, pointing at the wrong upstream id, they weren't doing anyway). A dedicated post-publish package smoke test could re-add that later if wanted.
No workflow changes — the root cause was the sample references, not the CI.