Skip to content

Conversation

@PetrDlouhy
Copy link
Contributor

This PR adds possibility to specify additional export parameters otherwise specified by custom admin export form.

I am planning to add some more docs and tests.

@PetrDlouhy
Copy link
Contributor Author

@timthelion What do you think about this modification? Are you OK with the usage of JSONField? Other fields doesn't use it even if they contain JSON data, but I expect that originates in time when JSONField wasn't part of Django.

@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.61%. Comparing base (7a9ec54) to head (8bcc25f).

Files with missing lines Patch % Lines
import_export_celery/models/exportjob.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   56.76%   56.61%   -0.16%     
==========================================
  Files          10       10              
  Lines         377      378       +1     
  Branches       57       57              
==========================================
  Hits          214      214              
- Misses        160      161       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PetrDlouhy PetrDlouhy force-pushed the add_kwargs_data branch 2 times, most recently from 57d59e9 to 8bcc25f Compare August 19, 2024 07:27
@PetrDlouhy PetrDlouhy marked this pull request as ready for review November 24, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants