Repository navigation
fix: add ambient coverage test and restrict open()/create() file handles - #17
Merged
Merged
Conversation
Ambient: compile-time test ensures Cap<Ambient> satisfies Has<P> for every permission type — catches impl_ambient! omissions at build time. File handles: open() now returns ReadFile (Read+Seek, no Write) and create() returns WriteFile (Write+Seek, no Read), closing the capability leak where FsRead holders could write to opened files via std::io::Write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ambient: compile-time test ensures Cap satisfies Has
for
every permission type — catches impl_ambient! omissions at build time.
File handles: open() now returns ReadFile (Read+Seek, no Write) and
create() returns WriteFile (Write+Seek, no Read), closing the capability
leak where FsRead holders could write to opened files via std::io::Write.