fix(example): enforce sub+sid keying for backchannel logout session index - #53
Open
frederikprijck wants to merge 1 commit into
Open
fix(example): enforce sub+sid keying for backchannel logout session index#53frederikprijck wants to merge 1 commit into
frederikprijck wants to merge 1 commit into
Conversation
…ndex Per the OIDC Back-Channel Logout spec, when both sub and sid are present in the logout token the RP must match both. Encode sub into the index key (session:<sid>:<sub>) so the sub cross-check is structural rather than a runtime comparison, and skip deletion when either claim is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subandsidare present in the logout token, the RP must match both when identifying the session to enddeleteByLogoutTokenin the Redis store example matched only onsid, ignoringsubsubinto the session lookup index key (session:<sid>:<sub>), making the cross-check structural rather than a runtime comparison — if the key doesn't exist, neithersidnorsubmatched