docs(auth0-express): clarify migration guide (empty sid, first-read vs next-write, dedupe) - #48
Merged
Merged
Conversation
A migrated session's sid falls back to '' when neither the legacy session nor the ID token carries one. Backchannel logout resolves sessions by sid, so such a session cannot be targeted by a logout token, and a store that indexes by sid without guarding the empty string collapses every sid-less session onto one shared key. Document the caveat in the migration guide and the transformer, and point at the example store's existing `if (sid)` guard.
Since the stateful store upgrades on first read (not the caller's next write), the zero-downtime intro's blanket 'on the next write' was wrong for stateful sessions. Distinguish stateless (next write) from stateful (first read) and link to the detailed section that already draws the distinction.
…tore Two adjacent comment blocks both explained the 'mirror appSession's exp > epoch()' expiry check; merge them into one. Leftover from an earlier change.
cschetan77
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation and comment clarifications for the express-openid-connect migration. No behavioural change.
sidcaveat: a migrated session'ssidfalls back to''when neither the legacy session nor the ID token carries one. Backchannel logout resolves sessions bysid, so such a session can't be targeted by a logout token, and a store that indexes bysidwithout guarding the empty string collapses everysid-less session onto one shared key. Documented in the guide and the transformer, pointing at the example store's existingif (sid)guard.expcomment in the stateless store.Test plan
npm test— 264 passing (baseline, docs-only)npm run build,eslint— cleanPart of a 3-PR split of the migration review findings (independent, not stacked).