fix: move all .of(context) out of the widget tree and into a variable#194
Open
PureTryOut wants to merge 4 commits intoaustinried:mainfrom
Open
fix: move all .of(context) out of the widget tree and into a variable#194PureTryOut wants to merge 4 commits intoaustinried:mainfrom
PureTryOut wants to merge 4 commits intoaustinried:mainfrom
Conversation
I guess fvm changed the way it does it's configuration at some point, but rather than having .fvm/fmv_config.json checked in .fvmrc should be checked in. The .fvm directory is used to store files and symlinks related to the installed Flutter version and as such should not be commited at all.
Seettings in there can be different per user and should be, it should not be committed
At the time of writing the latest Flutter version.
At some places <something>.of(context) was used multiple times in the same widget. This, although small, can have an impact on performance that's just plain unnecessary. It's better to just get things you need out of the context first before you do anything else.
PureTryOut
force-pushed
the
fix/context-in-build
branch
from
10280a9 to
eaffffa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains commits from #193, merge that first.