Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
aura-historia-staging | ed903d7 | Commit Preview URL Branch Preview URL |
Apr 14 2026, 09:20 PM |
|
For me, the currency selection is a user preference. That’s why it’s stored in UserPreferences, just like trackingConsent. Specifically, this means that the value(currency) it’s stored in localStorage (so it’s still there after a page reload) and in a cookie (so the server already knows the currency when the page first loads and renders it directly in the correct currency). For users who log in, the same thing happens, plus backend sync is added, which means, the backend value (currency) overrides the local value (localStorage) because the selector reads the currency from UserPreferences (and those are stored in localStorage). This ensures that the backend value is always displayed after login and that the setting is preserved across devices. And when a logged-in user changes the currency, localStorage and the cookie are updated immediately, and a PATCH request is sent to the backend at the same time, of course. |
bruderj15
left a comment
There was a problem hiding this comment.
Dropdown entries aren't aligned.
This reverts commit ee66620.
lfranke42
left a comment
There was a problem hiding this comment.
Currency selection doesn't survive refresh. Get's reset back to default euro when not signed in.
|
@BauZee please note the changes here: https://github.com/aura-historia/internal-api/blob/master/CHANGELOG.md#2026-04-13---expanded-currency-support-backend822 A whole lot more currencies have been added. All of them are to be fully supported. EDIT: Not yet deployed |
Let me know when it's deployed |
# Conflicts: # src/components/common/Footer.tsx
bruderj15
left a comment
There was a problem hiding this comment.
On e.g. search results the ISO 4217 currency codes are displayed for some currencies. Can you instead display the currency-symbol there?
(Everywhere where currencies are displayed, nut just search).
Also revisit the actual formatting.
Some currencies use , over ..
Some prefix the currency-sign, some postfix it.
This should be tied to the locale, not the currency. As far as I can tell this is currently implemented correctly. |
Symbols are now used everywhere instead of ISO currency codes. This was generated automatically by Intl.NumberFormat, but I am now replacing the ISO currency codes with the corresponding symbols. Regarding the second point: We use Intl.NumberFormat with the user locale everywhere -> this automatically handles the decimal separators (i.e., |
lfranke42
left a comment
There was a problem hiding this comment.
Currency still resets when refreshing the page, also the currency button has a differnt border then the language selection button. They should look the same imo
…feature/currency-selector
|
That was my mistake, I accidentally added a fallback that kept overriding the saved currency. Reverted it as it was, works now. |


No description provided.