Fibon code #59
Open
Fibon code #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Skully
reviewed
Oct 4, 2020
Comment on lines
+30
to
+66
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| /* | ||
| * public double fibo(int n) | ||
| { | ||
| if(n<=2) | ||
| f=1; | ||
| else | ||
| f=fibo(n-1)+fibo(n-2); | ||
| return f; | ||
|
|
||
| } | ||
|
|
||
| public double fibo1(int n) | ||
| { | ||
| if(mem[n]!=0) | ||
| f=mem[n]; | ||
| else if(n<=2) | ||
| f=1; | ||
| else | ||
| f=fibo1(n-1)+fibo1(n-2); | ||
| mem[n]=f; | ||
| return f; | ||
|
|
||
| } | ||
| */ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /* | |
| * public double fibo(int n) | |
| { | |
| if(n<=2) | |
| f=1; | |
| else | |
| f=fibo(n-1)+fibo(n-2); | |
| return f; | |
| } | |
| public double fibo1(int n) | |
| { | |
| if(mem[n]!=0) | |
| f=mem[n]; | |
| else if(n<=2) | |
| f=1; | |
| else | |
| f=fibo1(n-1)+fibo1(n-2); | |
| mem[n]=f; | |
| return f; | |
| } | |
| */ |
Collaborator
There was a problem hiding this comment.
You could remove the commented-out sections to make your code clean :)
Collaborator
There was a problem hiding this comment.
Possibly in the other branch too..
Collaborator
There was a problem hiding this comment.
Anyway, I've added the Hacktoberfest-accepted labels to your PRs, so the Hacktoberfest website count them as valid PRs.
Also, since fibonacci numbers are whole numbers, do you need to use the double datatype?
Author
There was a problem hiding this comment.
It is taken as double to have larger range than int.We can use long as well.
Collaborator
There was a problem hiding this comment.
Yes, long would be the more appropriate choice.
Mr-Skully
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.