Skip to content

fix(pty-proxy): resolve bare zsh interpreter path in init guard - #3681

Open
davidolrik wants to merge 2 commits into
atuinsh:mainfrom
davidolrik:pty-proxy-shell-path
Open

fix(pty-proxy): resolve bare zsh interpreter path in init guard#3681
davidolrik wants to merge 2 commits into
atuinsh:mainfrom
davidolrik:pty-proxy-shell-path

Conversation

@davidolrik

Copy link
Copy Markdown
Contributor

A smaller fix for #3606 that resolves a bare ssh to its full path.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR resolves bare zsh interpreter names before starting the PTY proxy. The main changes are:

  • Resolve non-absolute ZSH_ARGZERO values through PATH.
  • Forward the resolved path to atuin pty-proxy.
  • Update init-script assertions for the new logic.

Confidence Score: 4/5

Relative zsh interpreter paths can select the wrong binary and need correction before merging.

  • Bare zsh values are resolved as intended.
  • Relative paths such as ./custom/zsh are discarded instead of resolved.
  • The proxy can start a different zsh from the one that loaded the init script.

crates/atuin-pty-proxy/src/pty_proxy.rs

Important Files Changed

Filename Overview
crates/atuin-pty-proxy/src/pty_proxy.rs Adds zsh path resolution, but replaces valid relative interpreter paths with a potentially different binary from PATH.

Reviews (1): Last reviewed commit: "fix(pty-proxy): resolve bare zsh interpr..." | Re-trigger Greptile

Comment thread crates/atuin-pty-proxy/src/pty_proxy.rs Outdated
@davidolrik
davidolrik force-pushed the pty-proxy-shell-path branch 2 times, most recently from 3dcca1b to f19c18a Compare July 27, 2026 23:05
@davidolrik
davidolrik force-pushed the pty-proxy-shell-path branch from f19c18a to 05a5fd2 Compare July 28, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant