fix(theme): fix low-contrast annotation color in default and autumn themes - #3646
Open
hexonal wants to merge 1 commit into
Open
fix(theme): fix low-contrast annotation color in default and autumn themes#3646hexonal wants to merge 1 commit into
hexonal wants to merge 1 commit into
Conversation
…hemes The default and autumn themes used Color::DarkGrey for Meaning::Annotation, which is used to style the directory/user/host columns and header in the history popup. On many dark-background terminals this is barely visible. Switch both to steelblue, the same color the marine theme already uses for Annotation and which doesn't have this problem. Fixes atuinsh#3539
Contributor
Greptile SummaryThis PR improves annotation contrast in built-in themes. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(theme): fix low-contrast annotation ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3539
The
defaultandautumnthemes both setMeaning::AnnotationtoColor::DarkGreyincrates/atuin-client/src/theme.rs. This meaning styles the directory/user/host columns and header in the history TUI popup (history_list.rs,interactive.rs,inspector.rs), and on many dark-background terminalsDarkGreyrenders as nearly the same color as the background, making that text unreadable.The
marinetheme doesn't have this problem because it already uses"steelblue"forAnnotation. This PR changesdefaultandautumnto use the same"steelblue"value, which keeps reasonable contrast on both light and dark terminal backgrounds.Added a test asserting
default,autumn, andmarineall resolveAnnotationto the same color, so a future revert toDarkGreywould fail CI.