Cleanup pass for dead code and docs#25
Merged
Merged
Conversation
Delete the experimental Claude runner frontend so the Claude integration only exposes Nudge's primary hook, setup, and docs surfaces. Remove the command wiring and the supporting process, stream, and terminal UI modules. This is intentionally breaking for anyone invoking nudge claude run; they should run Claude Code directly with Nudge installed as hooks instead. Verification: cargo fmt --all; cargo test -p nudge -- --test-threads=1; cargo run --quiet -p nudge -- claude --help.
Stop invoking cargo build and cargo run from inside parallel integration tests. Cargo already builds package binaries for integration tests and exposes the executable path through CARGO_BIN_EXE_nudge, so the tests can launch that binary directly. This removes contention on cargo package-cache and artifact-directory locks, avoids recursive cargo process fan-out, and keeps the default parallel test runner supported. Verification: cargo fmt --all; cargo test -p nudge; five repeated default-parallel cargo test -p nudge runs all passed.
Delete the stale claude-run plan, the deprecated Claude-specific hook model, and the deprioritized synthetic benchmark package so the repo stays focused on Nudge's hook/setup/rule workflow. Move the small Claude hook setup JSON structs into the claude setup command before deleting the old nudge::claude module. Narrow the workspace to packages/nudge and prune benchmark-only lockfile entries. Verification: cargo fmt --all; cargo test -p nudge; cargo test --workspace.
Split the large rules schema implementation into focused matcher modules for content, syntax, paths, project state, and URLs while keeping the public schema facade intact. Extract the check command into smaller scan and issue-building steps so the command entrypoint reads as the workflow instead of carrying all rule traversal logic inline. Share JSON hook merging between Claude and Codex setup to remove duplicated object/array handling, and update local architecture docs for the new schema layout. Verification: cargo fmt --all; cargo test -p nudge; cargo clippy -p nudge --all-targets --all-features -- -D warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
nudge claude runcommand, and the oldnudge::claudeagent-runner module. Keeping them made the workspace, docs, tests, and dependency graph harder to understand.nudge claude run, importnudge::claude, or depend onpackages/benchmarkwill need to stop using those deleted paths.nudge check.checkcommand is decomposed into smaller scan and issue-building steps, and Claude/Codex setup now shares JSON hook merging logic.Testing steps performed
Surprising changes / Notes