Skip to content

Update docker images#161

Merged
jssblck merged 5 commits into
mainfrom
chore/docker/update
Nov 25, 2025
Merged

Update docker images#161
jssblck merged 5 commits into
mainfrom
chore/docker/update

Conversation

@jssblck
Copy link
Copy Markdown
Contributor

@jssblck jssblck commented Nov 25, 2025

Updates Docker image bases from bookworm to trixie, except for minio which got ported to alpine due to the fact that the MinIO team no longer provides a prebuilt OSS image (reference: minio/minio#21647).

Validated this works by running E2E tests:

E2E_DOCKER=true cargo test --package attune --test it --all-features --release
         Finished `release` profile [optimized] target(s) in 0.73s
          Running tests/it/main.rs (target/release/deps/it-4587cdde45d24684)

     running 2 tests
     test e2e_host ... ignored, because variable E2E_HOST not found
     test e2e_docker ... ok

     test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 36.34s

@jssblck jssblck requested review from Copilot and elldritch November 25, 2025 01:16
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
attune-docs-site Ignored Ignored Preview Nov 25, 2025 5:21am

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Docker base images across the project, upgrading Rust from version 1.89.0 to 1.91.0 and MinIO from RELEASE.2025-04-08T15-41-24Z-cpuv1 to RELEASE.2025-10-15T17-29-55Z. Since MinIO no longer provides prebuilt Docker images, the update includes building MinIO from source using a multi-stage Docker build.

Key Changes:

  • Upgraded Rust base image to version 1.91.0
  • Implemented custom MinIO Docker build from source using golang:1.24-alpine
  • Modified entrypoint script to use /bin/sh instead of /bin/bash for Alpine compatibility

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docker/attune/Dockerfile Updated Rust base image to 1.91.0
docker/attune-ee/Dockerfile Updated Rust base image to 1.91.0
docker/minio/Dockerfile Replaced prebuilt MinIO image with multi-stage build from source at RELEASE.2025-10-15T17-29-55Z
docker/minio/entrypoint.sh Changed shebang to /bin/sh and removed pipefail option for Alpine compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@elldritch elldritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you check against the user's CVEs too and make sure that these new packages are outside the affected version list.

Comment thread docker/attune-ee/Dockerfile Outdated
@jssblck
Copy link
Copy Markdown
Contributor Author

jssblck commented Nov 25, 2025

Make sure you check against the user's CVEs too and make sure that these new packages are outside the affected version list.

Done, communicated with them in Slack! 👍🏻

@jssblck jssblck merged commit 568b009 into main Nov 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants