Fix deep_sleep_hold with esp-idf >= 5.4 #2063
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`esp:deep_sleep_hold_en/0` and `esp:deep_sleep_hold_dis/0` nifs were disabled with esp-idf greater than 5.4 because macros used by esp-idf to define if they exist changed (5.3.2+ was an exception). Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Contributor
|
I introduced these complex conditionals here: https://github.com/atomvm/AtomVM/pull/1392/changes adjusting them for P4 support. It's evolved and the mass production P4 now supports deep sleep hold.. see espressif/esp-idf@c17644a So I suggest basically reverting the complexity to Then 5.3 P4 may fail, but afaik 5.3 doesn't support the new P4 (fully), and it's only 5.5.2, and a future 5.4.4 that supports (both?) (eg. we may see issues on current v5.4.3 - and need to use |
petermm
added a commit
to petermm/AtomVM
that referenced
this pull request
Jan 20, 2026
Supercedes: atomvm#2063 CI: Only test release-v5.4 and 5.5.2 for ESP32P4, due to their support for both P4 revisions. Changelog fixes and additions. Other minor fixes related to CI. Signed-off-by: Peter M <petermm@gmail.com>
petermm
added a commit
to petermm/AtomVM
that referenced
this pull request
Jan 20, 2026
Supercedes: atomvm#2063 CI: Only test release-v5.4 and 5.5.2 for ESP32P4, due to their support for both P4 revisions. Changelog fixes and additions. Other minor fixes related to CI. Signed-off-by: Peter M <petermm@gmail.com>
bettio
added a commit
that referenced
this pull request
Jan 22, 2026
Fix ESP32-P4 builds and deep_sleep_hold Supercedes: #2063 CI: Only test release-v5.4 and 5.5.2 for ESP32P4, due to their support for both P4 revisions. Changelog fixes and additions. Other minor fixes related to CI. (simulator has gotten task_wdt support but, it's currently broken P4) These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp:deep_sleep_hold_en/0andesp:deep_sleep_hold_dis/0nifs were disabled with esp-idf greater than 5.4 because macros used by esp-idf to define if they exist changed (5.3.2+ was an exception).These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later