Repository navigation
Conversation
kuanih
marked this pull request as ready for review
August 15, 2026 10:31
Contributor
|
Thanks for sending this, and welcome. It's a good instinct to fix a table delimiter that looks off. I went to verify it before merging and it turns out the original row was already valid. GFM requires one or more hyphens per delimiter cell, not three, so const before = "| | llmwiki | Atomic Memory |\n|--|---------|---------------|\n| **A** | b | c |\n";
const after = "| | llmwiki | Atomic Memory |\n| --- | --- | --- |\n| **A** | b | c |\n";
// both render a <table>, and the output HTML is byte-identicalSo the table renders correctly on I'm going to close this one, but two things:
Thanks again for taking the time. Hope to see another PR from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The first delimiter cell used only two hyphens. GFM table delimiter cells require at least three.
Validation
git diff --checknpx tsc --noEmitnpm run buildnpm test(4,860 passed, 3 skipped)npm run fallow:ci